dooble icon indicating copy to clipboard operation
dooble copied to clipboard

Issue with visited links color under QT6.

Open aja097 opened this issue 1 year ago • 3 comments

Hi,

It looks there is an issue with the visited links color when compiled with QT6 (version 6.4.3 or 6.5.3 or 6.7.2) which is not happening when compiled under QT5. As examples, three first screenshots under QT5, three other screenshots under QT6. This issue is present with Dooble version 2024.01.25 to 2024.08.20.

Under QT5 qt5-1 qt5-2

aja097 avatar Sep 22 '24 12:09 aja097

qt5-3

Under QT6

qt6-1 qt6-2 qt6-3

Otherwise, i did not find an option to choose links or visited links colors. As you can see on screenshot 3 under QT5, with dark mode, color difference between them is pretty difficult to notice on some pages. I can manage per page to change the links colors (not very convenient when several pages open) but it is not valid for a new page or any other page. And i do not know how to force my preferred colors and have them by default for all pages.

Maybe an option could be set for that purpose ?

Thanks !

aja097 avatar Sep 22 '24 13:09 aja097

I looked and did not find anything about visited links color.

textbrowser avatar Oct 03 '24 13:10 textbrowser

Oh, you mean on your side under QT6, visited links color does change compared to unvisited links ? I tried with a blank config and it is still the same. As a note, this does not happen with Falkon Browser or even Viper Browser under QT6, visited links color properly change. I wonder why ...

aja097 avatar Oct 03 '24 15:10 aja097

There is a problem with the Visited Links file. Visits are recorded correctly in Qt 5.

textbrowser avatar Apr 03 '25 02:04 textbrowser

Oh, OK. Do you think you could correct for QT6 ?

aja097 avatar Apr 03 '25 17:04 aja097

Qt 5 good, Qt 6 not good. Without a software change. It's a curios problem.

textbrowser avatar Apr 05 '25 13:04 textbrowser

The default-profile in Qt 6 is an off-the-record profile. In Qt 5, it's a proper profile.

textbrowser avatar Apr 05 '25 15:04 textbrowser

Not sure i really understand, sorry. Nevertheless i checked in my home dooble config folder. When Qt 5, the visited link file, after a browsing session has been changed (updated). When Qt 6 this file not changed as not updated, maybe not even read properly. This file is changed after a browse with Falkon or even with the simplebrowser that can be compiled as a QT example.

aja097 avatar Apr 05 '25 18:04 aja097

Completed Kiki. Off to delivery.

textbrowser avatar Apr 05 '25 22:04 textbrowser

Thanks a lot !!!!! Works for me. Maybe not related but now, checking the disable-reading-from-canvas option kills Dooble (checked with QT6.7.3 and QT 6.8.1). Was still OK with version 2024-11-23.

aja097 avatar Apr 06 '25 13:04 aja097

It doesn't kill my Dooble.

textbrowser avatar Apr 06 '25 14:04 textbrowser

I cannot test with all versions of Qt. There are 6.0 to 6.9.

textbrowser avatar Apr 06 '25 14:04 textbrowser

Oh. The new profile is at fault because it doesn't exist.

textbrowser avatar Apr 06 '25 14:04 textbrowser

Because of Qt 6.6 and newer.

textbrowser avatar Apr 06 '25 14:04 textbrowser

Yes. I had to create a brand new profile to make it work. With this new profile, checked options that i had before but prevent Browser to start. Did test all checking options one by one until i get the one that prevent my Dooble to start. Furthermore, when started from console, get the message : "Release of profile requested but WebEnginePage still not deleted. Expect troubles !" and have a population of : .org.chromium.Chromium.xxxxx in my ~/.dooble/WebEnginePersistentStorage folder

aja097 avatar Apr 06 '25 15:04 aja097

Done done.

textbrowser avatar Apr 06 '25 16:04 textbrowser

Bravo & bravo !!! Nevertheless changes led to a small issue : checking dark mode nor valid anymore. Not a big issue as ok when :"export QTWEBENGINE_CHROMIUM_FLAGS=--force-dark-mode" before launching Dooble

aja097 avatar Apr 06 '25 20:04 aja097

Done-done, again. :P

textbrowser avatar Apr 06 '25 23:04 textbrowser

The mode of darkness should be fine now.

textbrowser avatar Apr 06 '25 23:04 textbrowser

Yes it is ! Thanks again. A side note : since the visited links modification, my setting page is not in french anymore (dictionaries ok, main window and tabs ok. Just options labels in the setting page stay in english)

aja097 avatar Apr 07 '25 09:04 aja097

Show picture.

textbrowser avatar Apr 07 '25 10:04 textbrowser

Dooble Settings?

textbrowser avatar Apr 07 '25 11:04 textbrowser

Made the translator before interface thingies are created. Try soon because we release today anyway. Today now.

textbrowser avatar Apr 07 '25 12:04 textbrowser

Also read release notes for detail results. Or not.

textbrowser avatar Apr 07 '25 12:04 textbrowser

No need pictures. Works now with last commit. Thanks !!! (Did read release notes :-) )

aja097 avatar Apr 07 '25 14:04 aja097

Everything in French ...

aja097 avatar Apr 07 '25 14:04 aja097