Teun van den Brand

icon location Amsterdam icon location Currently consulting for Posit PBC. Previously computational PhD student in @deWitLab with an interest in chromatin biology and gene regulation.

Results 906 comments of Teun van den Brand

Update embedded svglite to v2.10+ to gain pattern support.

> The reason is stability of SVG generation. I find this argument very reasonable, but is it an option to change the device name from `"devSVG"` to something else so...

Update embedded svglite to v2.10+ to gain pattern support.

In addition to pattern support, it would be nice to have support for other newer graphical features as well (clipping paths, masks, compositing/blending, affine transformations, glyphs and fill/stroke paths).

Compatability with ggplot2 3.6.0

Thanks for the swift review! If these changes are suboptimal, you can see this PR as just pointing out some tests that are incompatible with the upcoming ggplot2 release and...

`pseudo_log_trans()` doesn't work when mapped to color or fill

The transformation should be mostly irrelevant for binned scales, the only thing that would matter are the breaks. The log10 breaks have a different default break algorithm than the other...

`pseudo_log_trans()` doesn't work when mapped to color or fill

Maybe the algorithm needs to be made robust, or at least throw a more informative error

Vague documentation or incorrect behaviour in the breaks_* functions

Would it be more clear if the phrase in the documentation went: > a vector of length 2 that represent the data range

Vague documentation or incorrect behaviour in the breaks_* functions

I mostly agree, there should be some normalisation of the `x` argument so that the functions always operate on a sorted vector of length 2 with no non-finite elements, like...

Using 'label_number' at package top-level generates R CMD check NOTE about '...'

What does WAI mean?

Using 'label_number' at package top-level generates R CMD check NOTE about '...'

The function does work as intended: `...` arguments in the function factory are forwarded to `base::format()` when used to label numbers. ``` r foo nchar() #> [1] 7 7 7...

Using 'label_number' at package top-level generates R CMD check NOTE about '...'

Yes that seems right to my mind. The 'may' part of the complaint is the operative word, but I can understand that from a static analysis of `foo`'s function body/formals...