nemo icon indicating copy to clipboard operation
nemo copied to clipboard

io_nemo fails with gfortran-10 (on mac)

Open teuben opened this issue 5 years ago • 22 comments

gfortran-10 is a more strict compiler, it does not like the varargs style it internally finds that is being used. This might be something for @jcldc possibly an extra flag to the compiler

teuben avatar Feb 07 '21 00:02 teuben

A more detailed look seems to show that gfortran-10 on linux works fine, but it's the one on the Mac that is broken. And to be clear, this is homebrew version 10.2.0 The working version on linux is Ubuntu 10.2.0-5ubuntu1~20.04 @jcldc might be partially happy.

teuben avatar Apr 10 '21 01:04 teuben

Indeed I am VERY happy ! Thanks Peter

jcldc avatar Apr 10 '21 12:04 jcldc

Not sure if you saw my first, or edited message, as i had to admit the problem is on mac only

teuben avatar Apr 10 '21 13:04 teuben

The compiler error on gcc-11 is: Error: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(8)/CHARACTER(*)). but by adding a -fallow-argument-mismatch flag, this passes the compiler now. There is still a runtime error in the testsuite.

teuben avatar Feb 04 '22 14:02 teuben

Hi, on which file do you get this error ?

jcldc avatar Feb 04 '22 14:02 jcldc

The compiler error on gcc-11 is: Error: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(8)/CHARACTER(*)). but by adding a -fallow-argument-mismatch flag, this passes the compiler now. There is still a runtime error in the testsuite.

on almalinux (redhat8 like) and gcc 11 activated, IO_NEMO test-suite pass (with -fallow-argument-mismatch enable)

jcldc avatar Feb 04 '22 15:02 jcldc

I've added this flag to the Makefile in io_nemo. I don't have runtime error on ubuntu20, but I'm looking into U21.10 where there is still a runtime error.

teuben avatar Feb 04 '22 15:02 teuben

My error was that from a previous test a 0 length plummer was there, then the rest fails. I would like to argue the testsuite scripts should write their files in a clean directory, so no side-effects like this could occur. By default the testsuite tree is removed. Other than this, the testsuite compiles and work again!

teuben avatar Feb 04 '22 15:02 teuben

I have a proposed solution (not committed yet), where RT= is set via commandline arg to the scripts. We could also make this the default. The other problem with /tmp/ is that the name would be shared by another user and thus the test would fail

teuben avatar Feb 04 '22 16:02 teuben

committed

teuben avatar Feb 04 '22 16:02 teuben