Alex Cameron

Results 90 comments of Alex Cameron

Taking some notes on where we'll have to make changes: - `pkg/types/hashedrekord/v0.0.1/entry.go:validate`: This seems to support most key types however, there's an explicit error check for Ed25519. There's some discussion...

@woodruffw @ret2libc As discussed, this is rough but I've opened it up for discussion since it probably makes sense to share some of this logic with Rekor. I haven't written...

I've shown in [d95ff74](https://github.com/sigstore/fulcio/pull/1517/commits/d95ff74a85eae11b9c6eca4e5e98b59e59b3de5a) how we can use an enum in `sigstore/protobuf-specs` to avoid redundancy in Fulcio and Rekor in CLI parsing, etc.

I'll follow up with some unit tests tomorrow.

> Please let me know if you figure out the issue with GTest, in the meantime I'll try figuring out the same. Hey @fvrmatteo, I'm taking a look. I'll let...

Ok, I have an idea of what's going on. The reason this is happening is not because there is no `INSTANTIATE_TEST_SUITE_P` macro (there is), it's because `gTests` is empty. This...

> @tetsuo-cpp In the past, I've copied what DynamoRIO does and used `@N@` as a delimiter, then ran a post-processing script to fix them up 🤮 https://github.com/Granary/granary/blob/master/scripts/post_process_asm.py#L12 Haha it's ugly......

Had a quick look at this today but still not 100% sure. From what I can see, there are a two different types of mismatches that may or may not...

@pgoodman I'll take a look at this again when I get the chance. Did you have any ideas on why we might have non-determinism in these tests?

Hey @yunluoai, what compiler are you building with?