proxy-wasm-go-sdk icon indicating copy to clipboard operation
proxy-wasm-go-sdk copied to clipboard

test framework: Implement ProxyGetProperty and ProxySetProperty

Open jmjolysc opened this issue 3 years ago • 1 comments

Hello there,

Currently, the ProxyGetProperty and ProxySetProperty methods are not implemented in proxytest. This prevents developers from writing more complete unit tests. Would you consider the implementation of those methods as a feature improvement?

When looking at the code, one approach could be adding a map (maybe string or []byte to []byte) in the hostEmulator data structure of the proxytest package, in order to store the state of properties. If you also think that's a straightforward approach, would you like me to give it a try and submit a pull request?

Thank you.

jmjolysc avatar Feb 17 '22 08:02 jmjolysc

sg! I would appreciate it if you could give it a shot. Thanks!

mathetake avatar Feb 17 '22 08:02 mathetake