func-e
func-e copied to clipboard
Published
20 hours ago •
tetratelabs
tetratelabs
`go test -race` fails
Build log:
==================
WARNING: DATA RACE
Read at 0x00c0004100c0 by goroutine 52:
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).GetPid()
/home/circleci/project/pkg/binary/envoy/runtime.go:99 +0x169
github.com/tetratelabs/getenvoy/pkg/binary/envoy/debug.retrieveOpenFilesData()
/home/circleci/project/pkg/binary/envoy/debug/lsof.go:60 +0x7f
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).handleTermination()
/home/circleci/project/pkg/binary/envoy/termination.go:36 +0x17a
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).RunPath()
/home/circleci/project/pkg/binary/envoy/run.go:60 +0x484
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).Run()
/home/circleci/project/pkg/binary/envoy/run.go:38 +0x106
Previous write at 0x00c0004100c0 by goroutine 50:
os.startProcess()
/usr/local/go/src/os/exec.go:25 +0x602
os.StartProcess()
/usr/local/go/src/os/exec.go:102 +0x92
os/exec.(*Cmd).Start()
/usr/local/go/src/os/exec/exec.go:416 +0x897
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).runEnvoy()
/home/circleci/project/pkg/binary/envoy/run.go:133 +0x2be
Goroutine 52 (running) created at:
github.com/tetratelabs/getenvoy/pkg/binary/envoytest.Run()
/home/circleci/project/pkg/binary/envoytest/util.go:57 +0x12a
github.com/tetratelabs/getenvoy/pkg/binary/envoytest.RunKill()
/home/circleci/project/pkg/binary/envoytest/util.go:81 +0x15a
github.com/tetratelabs/getenvoy/pkg/binary/envoy/debug.TestGetOpenFileStats.func1()
/home/circleci/project/pkg/binary/envoy/debug/lsof_test.go:35 +0x25c
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Goroutine 50 (running) created at:
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).RunPath()
/home/circleci/project/pkg/binary/envoy/run.go:57 +0x462
github.com/tetratelabs/getenvoy/pkg/binary/envoy.(*Runtime).Run()
/home/circleci/project/pkg/binary/envoy/run.go:38 +0x106
==================
this will fail until the e2e tests in the debug directory are moved to test/e2e and backfilled with unit tests
there are also some signal tests that fail, but should go away with #172
