Simon Guest comments

Results 58 comments of


                                            Simon Guest

Add not_ref()

@zesterer I had another look at what would be required to support `not()` et al for `BorrowInput`. Relaxing the trait constraints from `BorrowInput` and `ValueInput` to just `Input` seems to...

Add not_ref()

I wasn't able to transition to `ValueInput` for various reasons, so sticking with `BorrowInput`, which is surely the right thing. But by restructuring my parser, I was able to avoid...

Shorter match ignored, because longer potential match fails

I found quite a clean work-around to this problem which may be useful to others. My work-around is to define a subset of `Token` which I call `RecoveryToken`, and when...

Package for Nix?

For now I made myself a flake, which I have installed into my profile. Or it also works with `nix develop`. ``` { description = "Nix flake for nixml"; inputs...

Authorization fails when using an ssh-agent

I hit this problem, and found I had to use an ED25519 key, since it didn't work with my default RSA key. ``` let mut agent = AgentClient::connect_env().await?; let identities...

Option for restic restore to delete local files not in snapshot

Yes, you're right. I had a look at the code yesterday, and was surprised to see it doesn't actually look at the local files. That would seem to be another...

Use Path::real_parent instead of Path::parent

My follow-up draft PR (which wanted to be a stacked PR in this repo) is tesujimath/nushell#1 I have a few remaining tests to fix up, and will be test-driving these...

Use Path::real_parent instead of Path::parent

> I'm not sure I completely understand how this works. It would be helpful if you could provide an example of what behaviour would be changed by this. This is...

Use Path::real_parent instead of Path::parent

> It would be great if you could provide some failing cases in Nushell which would be solved with your changes. So currently there are no failing cases in Nushell,...

Use Path::real_parent instead of Path::parent

Yes, proposing essentially no longer using canonicalize anywhere at all. There's quite a lot to say here, so please take this as a timely but incomplete answer. `real_parent` absolutely cannot...