testng
testng copied to clipboard
Fix for #565
See commits messages
Hi @VladRassokhin,
There's a lot going on in this pull request and not all of it seems to be related to this threading bug, do you think you could break it into smaller ones? Specifically, I'd like to see which one exactly fixes the deadlock...
Thanks!
Hi Cedric,
Honestly, I don't have any inspiration right how to do anything with this changes :/ especially rearrange them. You may cherry-pick some simple commits (improvements), e.g. fddb95b, 983d0e6, and then i'll change pull request.
Specifically, I'd like to see which one exactly fixes the deadlock... 6623b2f - fixes deadlock cause 6051574 - adds deadlock detector (requires 239f9eb)
Totally understand, no worries. Thanks!
Cédric
On Mon, May 4, 2015 at 2:25 PM, Vladislav Rassokhin < [email protected]> wrote:
Hi Cedric,
Honestly, I don't have any inspiration right how to do anything with this changes :/ especially rearragne them. You may cherry-pick some simple commits (improvements), e.g. fddb95b, 983d0e6 https://github.com/cbeust/testng/commit/983d0e6b71070116b7ea7570c0c539cccd5ed1c9, and then i'll change pull request.
Specifically, I'd like to see which one exactly fixes the deadlock... 6623b2f https://github.com/cbeust/testng/commit/6623b2f3632d179df8cbe7a372abccb2b4d1df5f
- fixes deadlock cause 6051574 https://github.com/cbeust/testng/commit/6051574435cd6e4acea649ac2cb4f36972f2fff6
- adds deadlock detector (requires 239f9eb https://github.com/cbeust/testng/commit/239f9eb3be24e828f0d0483ee8362588eba601e0 )
— Reply to this email directly or view it on GitHub https://github.com/cbeust/testng/pull/570#issuecomment-98853388.