testng icon indicating copy to clipboard operation
testng copied to clipboard

Add XSD file for validation

Open juherr opened this issue 4 years ago • 8 comments

  • [x] Add test case(s)
  • [x] Update CHANGES.txt

TODO:

  • [x] upgrade schema version and remove deprecated
  • [ ] generate POJO from XSD.

juherr avatar Jun 08 '21 22:06 juherr

@juherr - If you find some time please help let me know your thoughts on the two questions i posted. Post which I think we can get this PR merged.

krmahadevan avatar Jun 10 '21 09:06 krmahadevan

@krmahadevan sure. But I don't see them. Did you finish the review?

juherr avatar Jun 10 '21 10:06 juherr

@krmahadevan sure. But I don't see them. Did you finish the review?

My bad. Forgot that. Now I finished it.

krmahadevan avatar Jun 10 '21 10:06 krmahadevan

@krmahadevan Please check the description again before merging. If you want to check XML samples, just add one suite file into the testng-core/src/test/resources/samples/xsd folder and my tests will check its validity. If you think the XML is wrong and the test keep to be green, it will mean that the schema is not good enough =)

juherr avatar Jun 10 '21 18:06 juherr

TODO: generate POJO from XSD.

juherr avatar Jun 10 '21 18:06 juherr

@juherr - Can you please fix the merge conflict ? We can merge this after that.

krmahadevan avatar Jun 12 '21 05:06 krmahadevan

ping @juherr

krmahadevan avatar Jun 14 '21 13:06 krmahadevan

ping @juherr

I am doing my best to close it asap ;)

juherr avatar Jun 14 '21 14:06 juherr