znai icon indicating copy to clipboard operation
znai copied to clipboard

landing: allow filtering by doc id, update to tsx

Open evinaik opened this issue 4 years ago • 2 comments

Added a single line additional check to filter by doc id (e.g. if the doc ID is sdlc but it isn't found anywhere else, it should still show up when searching for sdlc).

I also updated to *.tsx. Let me know if you want me to separate these into different PRs next time — I figured I'd update it while I'm here.

evinaik avatar Apr 14 '21 15:04 evinaik

I just tested this internally with some docs, and it looks like the search implementation isn't working quite correctly. Let me double check and see what's going on. Addressed all other comments (updating PR now) in the meantime.

evinaik avatar Apr 14 '21 16:04 evinaik

Thank you for converting to .tsx and hooks! as for the logic, maybe it is a good time to add a unit test to the search logic?

agreed, are there any existing tests I can model off of?

Also, I broke something in this PR (fixed the internal deployment, and the landing page is empty), so I'll need to figure that out as well. Will update soon

evinaik avatar Apr 14 '21 16:04 evinaik