vue-testing-library icon indicating copy to clipboard operation
vue-testing-library copied to clipboard

`@vue/compiler-sfc` peer dependency warning

Open edumudu opened this issue 2 years ago • 1 comments

Describe the bug When installing @testing-library/vue in a project with [email protected]+ and no @vue/compiler-sfc a warning of missing @vue/compiler-sfc peer dependencies is shown

To Reproduce Steps to reproduce the behavior:

  • Install the @testing-library/vue in a project with [email protected]+ and no @vue/compiler-sfc

You can view the warning in the terminal on Codesandbox

Expected behavior

Is expected to not show any warning about peer deps

Related information:

  • @testing-library/vue version: 6.6.0
  • Vue version: 3.2.37
  • node version: 16.14.0
  • npm (or yarn) version: [email protected]

Additional context

As of [email protected]+ the package @vue/compiler-sfc is included in the vue and can be accessed as vue/compiler-sfc. So is not needed anymore to install it separately, but currently, this project set it as a peer dependency and doesn't seem to use it directly

More info in the package README

I'm opening this issue to know if I am missing something, if it's alright I would be happy to open a PR if needed

edumudu avatar Jul 04 '22 00:07 edumudu

[email protected]+ also include @vue/compiler-sfc.

zhanglolo avatar Aug 31 '22 13:08 zhanglolo

+1 OP offered to open a PR, that would be nice.

davidysoards avatar Jun 26 '23 16:06 davidysoards

:tada: This issue has been resolved in version 8.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Feb 08 '24 10:02 github-actions[bot]