user-event icon indicating copy to clipboard operation
user-event copied to clipboard

fix: pressing arrow keys behavior on Radio buttons

Open tnyo43 opened this issue 2 years ago • 2 comments

What:

Fix a bug in the behavior of the keyboard operations on the radio buttons.

Why:

closes #1048

How:

  • updating test cases
    • increase amount of radio buttons in test situations to make the behavior easier to understand
    • fix the assertion of the test cases as it should be
  • fix the code to behave correctly

Checklist:

  • [N/A] Documentation
  • [x] Tests
  • [x] Ready to be merged

FYI

I know there is already another PR https://github.com/testing-library/user-event/pull/1049 for this bug. However, it has past several months since it stop its activity.

tnyo43 avatar May 25 '23 14:05 tnyo43

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e9fd2b83a4c1f996237f2d32e90ed083c500468:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
silent-sun-kxlrgr Issue #1048
zen-feather-hx0h14 Issue #1048

codesandbox-ci[bot] avatar May 25 '23 14:05 codesandbox-ci[bot]

@ph-fritsche @Gpx @kentcdodds can we merge this PR? If I can help something to merge, I will gladly cooperate with you.

tnyo43 avatar Sep 02 '23 14:09 tnyo43

resolved by #1049

ph-fritsche avatar Jan 29 '25 13:01 ph-fritsche