testing-playground icon indicating copy to clipboard operation
testing-playground copied to clipboard

Testing Playground breaks Miro

Open chodorowicz opened this issue 3 years ago • 2 comments

Bug Report 🐛

Testing Playground breaks Miro

Cannot read properties of undefined (reading 'startAppLoadingStep')

https://community.miro.com/ask-the-community-45/miro-broken-when-used-with-testing-library-extension-9916

CleanShot 2022-09-23 at 09 55 49

To Reproduce ✔️

  1. Install Testing Playground Extension
  2. Access Miro Board

Expected behavior 🤔

Miro should load correctly.

Suggested solution 🔦

Setting the extension to load on click fixes the problem.

Your Environment 💻

  • browser: Chrome
  • os: Mac

chodorowicz avatar Sep 23 '22 08:09 chodorowicz

It must be one of the patched methods on window that's causing issues. I'm happy to accept a pull that makes it safer by namespacing or even adding it behind an init function. Something like window.initTestingLibrary();

https://github.com/testing-library/testing-playground/blob/d85b47ac80a2343a921f572166360fc7d8f541c5/devtools/src/window/testing-library.js#L26-L41

smeijer avatar Sep 26 '22 13:09 smeijer

It's not that; I commented out the entire setup function and it's still broken.

The issue occurs when testing-library.js is injected.

keysmashes avatar Mar 15 '23 13:03 keysmashes