testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

Vue: Add example using props

Open travis5491811 opened this issue 4 years ago • 4 comments

Add example using props in reference to .1 in https://github.com/testing-library/vue-testing-library/issues/216#issuecomment-812368342

travis5491811 avatar Apr 02 '21 16:04 travis5491811

@afontcu Can you please have a look at this one? :)

MatanBobi avatar Apr 05 '21 09:04 MatanBobi

Hi! Thank you for taking the time 🙌

Given the fact that the guiding principle of Testing Lib is to test components in a real environement, I'm not entirely sure we should showcase a test using stubs as a "first" example. I would keep the test simpler, and focus only on props (which was the missing bit we identified on https://github.com/testing-library/vue-testing-library/issues/216 :)

We could either simplify the example, or maybe add some props to the Button example.

Again, thanks for this!

afontcu avatar Apr 05 '21 18:04 afontcu

Welcome @afontcu, I've reduced the example down to only focus on props. I also didn't realize my editor didn't pick up my spelling mistakes on the last commit. They showed immediately when I opened the patch. It's resolved now. Is this change okay?

travis5491811 avatar Apr 05 '21 18:04 travis5491811

@afontcu is this ready to be merged or can we close it? :)

MatanBobi avatar Feb 06 '22 07:02 MatanBobi