svelte-testing-library icon indicating copy to clipboard operation
svelte-testing-library copied to clipboard

Semantic Pull Requests is no longer maintaned

Open yanick opened this issue 3 years ago • 1 comments

https://github.com/zeke/semantic-pull-requests#readme

And indeed it doesn't seem to be running at all.

From the README, it seems we should be able to add a semantic.yml file with enabled: false to bypass the action. But we also need to add a replacement (the README also has alternatives. Must look at them)

yanick avatar May 31 '22 13:05 yanick

I've merged #193 to main so that we have an active semantic checker, but it seems that setting the config of Semantic Pull Request to disable is not enough to keep it at bay. The problem is that I don't know whose account has enabled that service for this repo. So until we find that, I guess we'll have to merge things using the override.

(and I changed the config of the repo so that squashed merges use the title of the PR as their commit message, so that the whole semantic stuff work)

yanick avatar May 31 '22 14:05 yanick

@yanick do you have access to the repository settings? The "Semantic Pull Requests" requirement is set - and thus can be removed - via branch protection rules on the main branch.

If not, do you know who we could ping that does have admin access to the repo? This is gonna be quite annoying for continuing maintenance

mcous avatar Jan 25 '24 01:01 mcous

I do, I do have access to the settings! \o/ I must have gotten those powers when I submitted changes to the documentation repo. I'll go and peek in the config after breakfast.

yanick avatar Jan 25 '24 15:01 yanick

Aaaand it should be disabled, now. We'll see for sure at the next PR. :crossed_fingers:

yanick avatar Jan 25 '24 16:01 yanick

PRs have been running smoothly 🚢, I think we can call this one resolved

mcous avatar Feb 02 '24 12:02 mcous

Yup. Closing!

yanick avatar Feb 02 '24 14:02 yanick