react-hooks-testing-library
react-hooks-testing-library copied to clipboard
React 18 migration for waitForNextUpdate repeats steps for waitForValueToChange instead
-
react-hooks-testing-libraryversion: N/A -
reactversion: N/A -
react-domversion (if applicable): N/A -
react-test-rendererversion (if applicable): N/A -
nodeversion: N/A -
npm(oryarn) version: N/A
Relevant code or config:
N/A
What you did:
I read https://github.com/testing-library/react-hooks-testing-library/blob/chore/migration-guide/MIGRATION_GUIDE.md#waitfornextupdate (section waitForNextUpdate).
What happened:
That section shows the following code snippet:
-await waitForValueToChange(() => result.current.state);
+const initialValue = result.current;
+await waitFor(() => {
+ expect(result.current).not.toBe(initialValue);
+});
Reproduction:
N/A, this is a docs change.
Problem description:
As you can see, it actually shows the migration path for waitForValueToChange which was already handled in the previous section. The code seems erroneously repeated.
Suggested solution:
Provide a proper code migration path, where the "before" state actually uses the waitForNextUpdate API.