pptr-testing-library icon indicating copy to clipboard operation
pptr-testing-library copied to clipboard

support puppeteer-core with pptr-testing-library/extend

Open catdad opened this issue 5 years ago • 1 comments

Current, the extend tries to require and modify the puppeteer module. However, I've found several use cases for using puppeteer-core to already-installed browsers and not require users to install an unnecessary version of chromium. One such example is when testing Electron apps.

It would be great if the extend helper could work with puppeteer-core as well. Currently, it hard-codes looking for puppeteer specifically. When it is not available, it errors. I did a quick check and it seems to work just fine with puppeteer-core. Perhaps it can be added as an extra libPrefix to check?

catdad avatar Sep 19 '20 23:09 catdad

Thanks for filing @catdad! Yeah this SGTM 👍

patrickhulce avatar Sep 20 '20 14:09 patrickhulce