eslint-plugin-testing-library icon indicating copy to clipboard operation
eslint-plugin-testing-library copied to clipboard

feat: allow ESLint v9

Open G-Rath opened this issue 1 year ago • 1 comments

Branched off of https://github.com/testing-library/eslint-plugin-testing-library/pull/926


Checks

Changes

  • adds ESLint v9 as an allowed peer dependency

Context

v9 can be officially supported given that #926 has the plugin running against v9 without issue

G-Rath avatar Aug 15 '24 21:08 G-Rath

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.33%. Comparing base (93a6ab9) to head (3d3f99f). Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files          44       46       +2     
  Lines        2419     2481      +62     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2390      +62     
  Misses         91       91              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 15 '24 22:08 codecov[bot]

Is this the proper PR to subscribe to for getting updated about making this plugin compatible working with eslint v9? I'm asking because it's been in draft state since August. Anything I could potentially help with to get it into review state?

niklaas avatar Oct 15 '24 15:10 niklaas

@niklaas this is good to go but currently a draft as it's branched off of #926 (which proves the plugin works with ESLint v9) and in turn that's branched off of #925 (which is the runtime fix required for the plugin to work with v9) - I've done them as dedicated PRs as I feel it's nice to have them in their own commits and released independently in case something comes up along the line.

While @Belco90 doesn't have to land my PRs, I suspect that he'll be happy with them so I think it's the one to subscribe to - alternatively you could subscribe to releases for this whole codebase since it's most likely the next release will include v9 support:

image image

G-Rath avatar Oct 15 '24 23:10 G-Rath

Thanks a lot! Appreciated the update. 🙇🏼

niklaas avatar Oct 16 '24 06:10 niklaas

:tada: This PR is included in version 6.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 18 '24 07:10 github-actions[bot]