eslint-plugin-testing-library icon indicating copy to clipboard operation
eslint-plugin-testing-library copied to clipboard

fix: replace use of deprecated methods

Open G-Rath opened this issue 1 year ago • 2 comments

Checks

Changes

  • introduced compat utilities that enable support for ESLint v9
  • replaced usages of context functions that were removed in v9 in favor of compat utils

Context

Resolves #924 Resolves #899

G-Rath avatar Aug 14 '24 19:08 G-Rath

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.31%. Comparing base (93a6ab9) to head (88ecc28). Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   96.23%   96.31%   +0.07%     
==========================================
  Files          44       45       +1     
  Lines        2419     2470      +51     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2379      +51     
  Misses         91       91              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 14 '24 19:08 codecov[bot]

#926 proves that this works with ESLint v7, v8, and v9 so I think this should be safe to merge as-is and then we'll be one step closer to supporting ESLint v9 officially

(the CI failure is just a flakey timeout - it should pass if rerun)

G-Rath avatar Aug 14 '24 21:08 G-Rath

@Belco90 @MichaelDeBoey would it be possible to get this and my follow-up PRs progressed, given that they can be released in a minor version?

G-Rath avatar Sep 12 '24 21:09 G-Rath

Thanks for your contribution, and sorry for the inactivity. I'll try to get this merged during the week.

Belco90 avatar Oct 14 '24 10:10 Belco90

@Belco90 no worries, let me know if there's anything I can do to help - just in case you've not seen it, I've got a few pull requests open which include ones that ultimately lead to allowing ESLint v9 which are chained off of each other.

In order they are:

  • #925 (this one)
  • #927 (optional)
  • #926
  • #928

I should be able to have them rebased within minutes of you landing the prior ones unless I'm sleep, but I can also do a single big PR if you're prefer.

Let me know what works best for you, and also if you have questions or want something done differently

G-Rath avatar Oct 15 '24 23:10 G-Rath

@G-Rath Amazing, thank you so much! I'm going to merge some other chore PRs first (like your editorconfig PR), then we can rebase this one and start reviewing in the order you mentioned.

Belco90 avatar Oct 17 '24 08:10 Belco90

@Belco90 this is good to go now!

G-Rath avatar Oct 17 '24 18:10 G-Rath

@G-Rath Ah sorry, this must be reformatted after I merged the prettier v3 upgrade.

Belco90 avatar Oct 17 '24 22:10 Belco90

@Belco90 done 🙂

G-Rath avatar Oct 17 '24 22:10 G-Rath

:tada: This PR is included in version 6.3.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 17 '24 22:10 github-actions[bot]