dom-testing-library icon indicating copy to clipboard operation
dom-testing-library copied to clipboard

fix: getQueriesForElement types

Open rodgobbi opened this issue 9 months ago • 1 comments

What:

Fix getQueriesForElement type.

Why:

Type definition for getQueriesForElement doesn't match the JS implementation.

How:

Add initialValue third parameter to the function signature.

Checklist:

  • [ ] Documentation added to the docs site N/A
  • [x] Tests
  • [x] TypeScript definitions updated
  • [x] Ready to be merged

rodgobbi avatar Mar 31 '25 10:03 rodgobbi

This change looks good to me. The failing build is something we'll have to look into, I will create an issue to look into this.

Thanks for checking @timdeschryver 👍

I noticed the CI failing and checked if it happened to other PRs and indeed it looked like some issue in every PR.

Lemme know when it gets fixed, I can merge with the main branch and push to fix if needed.

rodgobbi avatar Apr 03 '25 18:04 rodgobbi