angular-testing-library icon indicating copy to clipboard operation
angular-testing-library copied to clipboard

Move testing-library/dom dependency into peerDependencies

Open lacolaco opened this issue 1 year ago • 5 comments

ATL depends on TL/dom directly, but TL/user-event depends on that via peerDependencies.

https://github.com/testing-library/angular-testing-library/blob/main/projects/testing-library/package.json#L38

https://github.com/testing-library/user-event/blob/main/package.json#L73

In my project, after upgrading ATL to v16, that difference occurred version conflict errors at test. I solved that by adding TL/dom v10 to my own package.json to make TL/user-event to use v10.

I think my situation did not happen if the both libraries depend on TL/dom by the same peerDependencies way. How do you think? Could we change this dependency? @timdeschryver

lacolaco avatar May 13 '24 06:05 lacolaco