bump golang buster version to 1.19

[asabya]

fixes #1495

[galargh]

Hey, thank you for the PR 🥳

As for the original issue (https://github.com/testground/testground/issues/1495) it seems to me, it could also be addressed by:

• using either Go 1.16 or 1.17 if you want to stick with using local:go builder
• using docker:go as the builder (which would use Go from a docker image rather than your system installed one)

In a way, it is similar to https://github.com/testground/testground/pull/1370#issuecomment-1169634002

All in all, we definitely do want to upgrade Go so, once again, thank you very much for doing all this work but prior to that we might have to do a little assessment of what other systems will be affected by this change. Also, it seems that build-test-linux-test-go is failing on this branch.

[asabya]

Hey 👋

I'm using docker:go for running my test plans. I agree it was trying to access go from an image, but by default it was pulling 1.16-buster. I might have missed some config that could define the go image to pull.

I will check if I can if I can fix the build-test-linux-test-go, but i'm not sure what the following error means in the test.

=== CONT  TestBuildSelector
    selector_test.go:106: 
        	Error Trace:	selector_test.go:106
        	Error:      	An error is expected but got nil.
        	Test:       	TestBuildSelector
=== CONT  TestBuildSelector/exec:go/selectors
    testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

[galargh]

I'm using docker:go for running my test plans. I agree it was trying to access go from an image, but by default it was pulling 1.16-buster. I might have missed some config that could define the go image to pull.

OK, let's move with the issue analysis to the issue - https://github.com/testground/testground/issues/1495#issuecomment-1285000462.

I will check if I can if I can fix the build-test-linux-test-go, but i'm not sure what the following error means in the test.

It's complaining about this place https://github.com/testground/testground/blob/b9abcd96eea0fdea318684d10f542d9135547f32/pkg/build/selector_test.go#L110 where it is expecting an error.

[laurentsenta]

Thanks for taking the time to try this out! Closing this PR for now, similar to https://github.com/testground/testground/pull/1370, the issue was solved by using a build_base_image.