fastapi-vue icon indicating copy to clipboard operation
fastapi-vue copied to clipboard

Published 20 hours ago • verified publisher icon testdrivenio

Vue3 support

Open devmount opened this issue 1 year ago • 7 comments

Anybody interested in having this awesome project support Vue3? I can create a PR for that.

And many thanks @mjhea0 for writing the great tutorial for this project 👏🏻

devmount avatar Jul 25 '22 12:07 devmount

It would be great to have a modern version (Vue3/Vite + Pinia) of this project. I don't know how much I can contribute, but I'm interested. If you have something, maybe could you share that so we can have a look?

paolodina avatar Sep 09 '22 16:09 paolodina

Well I'm quite experienced in migrating Vue2 projects to Vue3 / composition API, so I can offer to do that (maybe it's best to keep this on a different branch though). If you would like to use Vite or Pinia as well, feel free to add / implement it on top.

devmount avatar Sep 09 '22 19:09 devmount

Wonderful, couldn't hope for better news.

paolodina avatar Sep 09 '22 21:09 paolodina

This tutorial is very good and I think it would be worth the effort to migrate to Vue3. Is there any progress here yet? :slightly_smiling_face:

KristjanESPERANTO avatar Oct 08 '22 08:10 KristjanESPERANTO

Yeah, I didn't have time yet. I try to have a PR ready in November. @paolodina @KristjanESPERANTO Can you review / test the PR when it's ready?

devmount avatar Oct 08 '22 11:10 devmount

@devmount thanks, ATM I'm less in hurry for this. So welcome for November (or when you can do that), in the meantime I had take up Vue 3 and yep, I can review. Btw, coming back from Svelte (which I found great but less mature), I can say Vue 3 is so nice and so similar to Svelte if you want to make it so.

paolodina avatar Oct 08 '22 13:10 paolodina

There are some new things for me to learn from this tutorial, but it will be also a good opportunity to test your new version. I'll be happy to do that. Thank you for your commitment, @devmount!

KristjanESPERANTO avatar Oct 08 '22 14:10 KristjanESPERANTO

@paolodina @KristjanESPERANTO I've implemented the changes to support Vue3 in #10. Feel free to review it, hope this is useful for you.

devmount avatar Nov 27 '22 13:11 devmount

@devmount: Nice job! 👍

In order to test this correctly, the tutorial would also have to be updated. For this it would make sense to put the tutorial into a markdown file.

@mjhea0: What do you think? Do you have the tutorial as markdown?

KristjanESPERANTO avatar Nov 27 '22 13:11 KristjanESPERANTO

@devmount I went back to Django again (mainly for the ORM). Probably I won't test your change along with FastAPI, nonetheless the PR looks good, thanks.

paolodina avatar Dec 02 '22 17:12 paolodina

Thanks for this, @KristjanESPERANTO! We're going to start updating the tutorial this weekend. I'll keep you posted.

mjhea0 avatar Dec 02 '22 18:12 mjhea0