testdouble
Rails 7.1 Support Question
:wave: Hey there!
Love all the OSS work that Test Double does - and all of the thought leadership that comes out of the crew.
I was working with a project to update it to 7.1, and the project uses this gem (and it's very helpful!)
I found the issue at hand, specifically - ActiveRecord::InternalMetadata no longer inherits from ActiveRecord::Base: https://github.com/rails/rails/commit/93ddf338a0763c2e6e81e8c9e64cea5cc891a523
Not a difficult fix - but I suppose I'm curious if this project is still something actively used by the Test Double team.
If this isn't the recommended path anymore - totally fine, and I'd love to know what the team prefers. If it is, however, I'm more than happy to submit a PR.
Thanks again for all you do!
@thewatts any plans to open PR? I have checked and your update works well for our project. Btw. I'm also enjoying using this gem :muscle:.
Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to ActiveRecord::InternalMetadata are definitely an issue I've run into as well.
If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.
PR #12 - 3a1b605 fixes this for 7.1 - but probably won't work with earlier versions.
Hey @thewatts, I've taken over ownership of this gem. Definitely looking into what it will take to have support for Rails 7.1. The changes to
ActiveRecord::InternalMetadataare definitely an issue I've run into as well.If you'd like to make a PR addressing those changes, that would be greatly appreciated. Otherwise, it's something I'm hoping to take care of soon.
Hey there!
Sorry - I didn't see the notification about your message!
I don't mind taking my code and submitting a PR :)
Hold tight