cypress-rails

cypress-rails copied to clipboard

In 3.1, rackup moved to a separate gem, so the server breaks on this line: https://github.com/testdouble/cypress-rails/blob/main/lib/cypress-rails/server/puma.rb#L13 `Rack::Handler` is undefined in this case, but I confirmed changing that line to `Rackup::Handler`...

keithlayne

Incompatible with Rails 7.2

28

The gem fails after upgrading an app to Rails 7.2, because `ActiveRecord::ConnectionAdapters::ConnectionPool#lock_thread=` does not exist anymore. There is a deprecation warning as well: ``` $ DISABLE_SPRING=1 RAILS_ENV=test bin/rake cypress:run cypress-rails...

ledermann

As described in https://github.com/testdouble/cypress-rails/issues/164#issuecomment-2408705618

azyzio

Hopefully takes care of https://github.com/testdouble/cypress-rails/issues/164. There are 3 significant changes in this PR: ### 1. Remove `lock_thread` on connection pool The commit that added `lock_thread` (https://github.com/testdouble/cypress-rails/commit/f6380859e82193c6a16bdbf2950b933054f65355) notes that > Transaction...

rosston

Rails 7.2 has introduced connection pinning in https://github.com/rails/rails/pull/50999 and removed the former method `lock_thread=`. This PR uses the new methods if they are available, otherwise the previous behavior remains. A...

ledermann