testcontainers
fix: reuse container requires name
... also sync Container should reuse ContainerAsync's drop impl.
This resolves https://github.com/testcontainers/testcontainers-rs/issues/742.
cc @DDtKey @the-wondersmith
Deploy Preview for testcontainers-rust ready!
| Name | Link |
|---|---|
| Latest commit | 499d5c61e67cfcc337e24941c9797c94666f16e0 |
| Latest deploy log | https://app.netlify.com/projects/testcontainers-rust/deploys/692d43a922732600080d6777 |
| Deploy Preview | https://deploy-preview-887--testcontainers-rust.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Let me fix the format issue.
... also it seems that tests rely on selecting by labels without container name, let me try to fine tune the impl.
Besides, we may later drop the "reusable-containers" flag and just deliver it by default. There is no extra dependency requirement.
@tisonkun I need to dig in to confirm when I get back to my desk, but I think there's some overlap here with the fix branch I'd previously asked you to test. Come to think of it actually, I need to actually get that branch up to date with main 🤔😅.
tl;dr I'll block some time out today to give this PR a closer look, and some time this week to get that branch fixed up and get a proper PR opened.
@the-wondersmith 👍🏻
I think this PR can resolve my remaining issue now. If @DDtKey or other maintainer can get it reveiwed, you may put your changes upon this one.
That said, I'm glad to learn any concrete suggestion to improve the patch in place. And there is still a pending issue (https://github.com/testcontainers/testcontainers-rs/pull/887#discussion_r2575699650) we need to decide before testcontainers-rs can go back to my testkit ><
Sorry for the delay with review @tisonkun! That looks like a valid fix regardless of reuse container functionality and helps to reuse the code
