testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

fix(kafka): Use wait strategy instead of deprecated wait_for_logs

Open Hugo-C opened this issue 2 months ago • 1 comments

Related to https://github.com/testcontainers/testcontainers-python/issues/874.

Since those containers first need to be started to know their exposed ports, we cannot use DockerContainer._wait_strategy. We have to keep checking logs manually in their own start methods.

Let me know if there is anything to change.

Hugo-C avatar Oct 14 '25 21:10 Hugo-C

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 79.52%. Comparing base (5c1504c) to head (c410486).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   79.78%   79.52%   -0.26%     
==========================================
  Files          14       14              
  Lines        1182     1182              
  Branches      184      184              
==========================================
- Hits          943      940       -3     
- Misses        197      201       +4     
+ Partials       42       41       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 15 '25 18:10 codecov[bot]