testcontainers
feat(nats): Client-Free(ish) NATS container
@totallyzen Closed previous PR because of dirty history and bad-merge.
Based of this comment - https://github.com/testcontainers/testcontainers-python/issues/446#issuecomment-1986860683 I removed hard dependency on the NATS client.
This PR does not require a client to work or validate at a basic level. However if a developer wants to use a client, there is test support for that.
@bearrito for what its worth we havent decided what we are doing with the dependencies yet - i was going to merge your PR as is after releasing whatever other fixes we can fit before we add features (things that have to bump minor version)
@alexanderankin No worries. If you guys decide to allow more dependencies. I can add to the extras and then remove the try/catch import
@alexanderankin I see the commit. Do you want me to resolve the merge conflict or are you guys still deciding on dependencies?
@bearrito my take at this point is that you can add it as a dev dependency - the point is more so to prevent enforcement of clients, not to make testing a hellscape.
I've reflected this in the latest changes on #460 as well, comment there instead on this if you agree!
what happened here? i am rebasing all the branches because too crazy otherwise
@alexanderankin I think I was in the middle of you doing that. What do you want me to do here?
@bearrito no problem, i just merged all the newer ones, about to rebase this one and merge it. thanks for your contribution and support here. let me know if you want to have a final look over in a few mins before i push and hit merge.