testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

add SingleStore container

Open vgerya opened this issue 2 years ago • 5 comments

I fixed pylint issues, but I still cannot set up requirements locally (macbook, m1, Python 3.10.10)

Collecting pymssql==2.2.7
  Using cached pymssql-2.2.7.tar.gz (170 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pymssql
  Building wheel for pymssql (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for pymssql (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      setup.py: platform.system() => Darwin
      setup.py: platform.architecture() => ('64bit', '')
      setup.py: platform.libc_ver() => ('', '')
      setup.py: include_dirs => []
      setup.py: library_dirs => []
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-13.3-arm64-cpython-310
      creating build/lib.macosx-13.3-arm64-cpython-310/pymssql
      copying src/pymssql/__init__.py -> build/lib.macosx-13.3-arm64-cpython-310/pymssql
      running build_ext
      cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c
      cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c
      building 'pymssql._mssql' extension
      creating build/temp.macosx-13.3-arm64-cpython-310
      creating build/temp.macosx-13.3-arm64-cpython-310/src
      creating build/temp.macosx-13.3-arm64-cpython-310/src/pymssql
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Users/vheria/.pyenv/versions/test-contaniers-venv/include -I/Users/vheria/.pyenv/versions/3.10.10/include/python3.10 -c src/pymssql/_mssql.c -o build/temp.macosx-13.3-arm64-cpython-310/src/pymssql/_mssql.o -DMSDBLIB
      src/pymssql/_mssql.c:747:10: fatal error: 'sqlfront.h' file not found
      #include "sqlfront.h"
               ^~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymssql
Failed to build pymssql
ERROR: Could not build wheels for pymssql, which is required to install pyproject.toml-based projects

vgerya avatar May 16 '23 11:05 vgerya

Thanks for the contribution, @vgerya. The GitHub Action run has now built the requirement files. Updating them (as described in the pull request template) should facilitate the tests passing.

tillahoffmann avatar May 17 '23 02:05 tillahoffmann

Thanks for the contribution, @vgerya. The GitHub Action run has now built the requirement files. Updating them (as described in the pull request template) should facilitate the tests passing.

Thank for support in review of this PR. There was a wrong import in doctest of SingleStoreContainer class. it's fixed

vgerya avatar May 17 '23 06:05 vgerya

There are still some issues with dependencies. Have a look here for step-by-step instructions: https://github.com/testcontainers/testcontainers-python/blob/main/.github/PULL_REQUEST_TEMPLATE/new_container.md

tillahoffmann avatar May 17 '23 20:05 tillahoffmann

I fixed pylint issues, but I still cannot set up requirements locally (macbook, m1, Python 3.10.10)

Collecting pymssql==2.2.7
  Using cached pymssql-2.2.7.tar.gz (170 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pymssql
  Building wheel for pymssql (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for pymssql (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      setup.py: platform.system() => Darwin
      setup.py: platform.architecture() => ('64bit', '')
      setup.py: platform.libc_ver() => ('', '')
      setup.py: include_dirs => []
      setup.py: library_dirs => []
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-13.3-arm64-cpython-310
      creating build/lib.macosx-13.3-arm64-cpython-310/pymssql
      copying src/pymssql/__init__.py -> build/lib.macosx-13.3-arm64-cpython-310/pymssql
      running build_ext
      cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c
      cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c
      building 'pymssql._mssql' extension
      creating build/temp.macosx-13.3-arm64-cpython-310
      creating build/temp.macosx-13.3-arm64-cpython-310/src
      creating build/temp.macosx-13.3-arm64-cpython-310/src/pymssql
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Users/vheria/.pyenv/versions/test-contaniers-venv/include -I/Users/vheria/.pyenv/versions/3.10.10/include/python3.10 -c src/pymssql/_mssql.c -o build/temp.macosx-13.3-arm64-cpython-310/src/pymssql/_mssql.o -DMSDBLIB
      src/pymssql/_mssql.c:747:10: fatal error: 'sqlfront.h' file not found
      #include "sqlfront.h" 
               ^~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymssql
Failed to build pymssql
ERROR: Could not build wheels for pymssql, which is required to install pyproject.toml-based projects

This issue can be fixed by https://stackoverflow.com/a/70333974/352839

vgerya avatar May 18 '23 07:05 vgerya

This issue can be fixed by https://stackoverflow.com/a/70333974/352839

Great pointer. However, this is not something that we can fix in this repo because it depends on the local runtime. Maybe a pointer somewhere in the documentation could be useful.

tillahoffmann avatar May 18 '23 16:05 tillahoffmann