testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Allow set arbitrary parameters multiple times

Open weixu365 opened this issue 6 years ago • 3 comments

@tillahoffmann Fixes based on comments in https://github.com/testcontainers/testcontainers-python/pull/34

  • Merge kwargs instead of override
  • Using kwargs to store all the settings to prevent named parameter conflict with kwargs

weixu365 avatar Aug 27 '19 12:08 weixu365

Codecov Report

Merging #35 into master will increase coverage by 0.2%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #35     +/-   ##
=========================================
+ Coverage   77.57%   77.77%   +0.2%     
=========================================
  Files          17       17             
  Lines         330      324      -6     
  Branches       21       22      +1     
=========================================
- Hits          256      252      -4     
+ Misses         59       58      -1     
+ Partials       15       14      -1
Impacted Files Coverage Δ
testcontainers/core/generic.py 100% <100%> (ø) :arrow_up:
testcontainers/core/container.py 87.5% <93.75%> (+1.6%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc956cc...739d177. Read the comment docs.

codecov-io avatar Aug 27 '19 13:08 codecov-io

@tillahoffmann, @SergeyPirogov Could you please have a review on this PR when you available?

weixu365 avatar Aug 29 '19 01:08 weixu365

this is quite useful. Why isn't getting merged? Any reason?

Can-Sahin avatar Jul 22 '20 10:07 Can-Sahin