testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Add memcached container

Open romulojales opened this issue 2 years ago • 2 comments

Adding Memcached container.

You have implemented a new container and would like to contribute it? Great! Here are the necessary steps.

  • [x] Create a new feature directory and populate it with the package structure described in the documentation. Copying one of the existing features is likely the best way to get started.
  • [x] Implement the new feature (typically in __init__.py) and corresponding tests.
  • [x] Add a line -e file:[feature name] to requirements.in and run make requirements. This command will find any new requirements and generate lock files to ensure reproducible builds (see the pip-tools documentation for details). Then run pip install -r requirements/[your python version].txt to install the new requirements.
  • [x] Update the feature README.rst and add it to the table of contents (toctree directive) in the top-level README.rst.
  • [x] Add a line [feature name] to the list of components in the GitHub Action workflow in .github/workflows/main.yml to run tests, build, and publish your package when pushed to the master branch.
  • [x] Rebase your development branch on master (or merge master into your development branch).

romulojales avatar Mar 21 '23 15:03 romulojales

@romulojales @pffijt Can you get this merged and released?

damjankuznar avatar Jun 22 '23 07:06 damjankuznar

@romulojales @pffijt Can you get this merged and released?

Hello @damjankuznar ,

I just rebased the PR with the latest main version.

Since I don't manage the project, I'm also waiting for the maintainers to review, and hopefully, approve my pr, so I could work with it without using my own fork.

romulojales avatar Jun 29 '23 16:06 romulojales

original commits are here - https://github.com/testcontainers/testcontainers-python/commits/romulojales/add-memcached

alexanderankin avatar May 11 '24 04:05 alexanderankin