testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Add Cockroach DB Container Support

Open joelhess opened this issue 3 years ago • 7 comments

You have implemented a new container and would like to contribute it? Great! Here are the necessary steps:

  • [x] You have added the new container as a module in the testcontainers directory (such as testcontainers/my_fancy_container.py).
  • [x] You have added any new python dependencies in the extras_require section of setup.py.
  • [x] You have added the extra_requires key to requirements.in.
  • [x] You have updated all python requirements by running make requirements from the root directory.
  • [x] You have added tests for the new container in the tests directory, e.g. tests/test_my_fancy_container.py.
  • [x] You have added the name of the container (such as my_fancy_container) to the test-components matrix in .github/workflows/main.yml to ensure the tests are run.
  • [x] You have rebased your development branch on master (or merged master into your development branch).

joelhess avatar Dec 19 '22 22:12 joelhess

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@7a9490a). Click here to learn what that means.

:exclamation: Current head dbfb587 differs from pull request most recent head d092695. Consider uploading reports for the commit d092695 to get more accurate results

Files Patch % Lines
testcontainers/cockroachdb.py 85.18% 1 Missing and 3 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage        ?   87.06%           
=======================================
  Files           ?       31           
  Lines           ?      866           
  Branches        ?       61           
=======================================
  Hits            ?      754           
  Misses          ?       79           
  Partials        ?       33           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 31 '22 15:12 codecov-commenter

I'm an engineer from CockroachDB - this looks good to me!

rafiss avatar Jan 03 '23 16:01 rafiss

Please let me know if there's anything else that I need to do to get this merged. I'm trying to keep it up to date with Master at this point.

joelhess avatar Jan 09 '23 14:01 joelhess

Please let me know if there's anything else that I need to do to get this merged. I'm trying to keep it up to date with Master at this point.

There a few more major-ish changes to prepare for v4.x (e.g. #296). I'd suggest not updating the PR until then (but thank you for putting the work in to keep it up to date). Shall I let you know when master is a bit more stable?

tillahoffmann avatar Jan 10 '23 16:01 tillahoffmann

Please let me know if there's anything else that I need to do to get this merged. I'm trying to keep it up to date with Master at this point.

There a few more major-ish changes to prepare for v4.x (e.g. #296). I'd suggest not updating the PR until then (but thank you for putting the work in to keep it up to date). Shall I let you know when master is a bit more stable?

Yes Please. Thanks for the follow up.

joelhess avatar Jan 10 '23 16:01 joelhess

@tillahoffmann Is the Main branch ready enough to update this to the new patterns?

joelhess avatar May 11 '23 18:05 joelhess

Yes, fingers crossed.

tillahoffmann avatar May 11 '23 20:05 tillahoffmann