testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Compose should use `compose_file_name=[]` or `None` by default

Open bitplane opened this issue 3 years ago • 2 comments

For some reason docker-compose up -d works subtly differently than docker-compose up -d -f docker-compose.yml when there are overrides files. I'm not sure why, but passing compose_file_name=[] fixes things for me locally as it doesn't build the -f list.

I think this should be the default, rather than defaulting to a specific file name.

Also, since it actually supports a list, the parameter name should be different so this is obvious

bitplane avatar Oct 25 '22 14:10 bitplane

Thanks for reporting. Do you have a code snippet to illustrate the issue?

tillahoffmann avatar Jan 06 '23 19:01 tillahoffmann

It was part of a project I was working on for a customer so can't really share. If I find time I'll create a test case, and if I have a failing test then I guess I might as well fix it and send a PR too. No promises at the moment as it's bottom of my priorities, so if anyone else wants to do it go for it.

bitplane avatar Jan 31 '23 14:01 bitplane