testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

Improve host detection

Open tuvshuud opened this issue 3 years ago • 2 comments

This PR will fix additional issue that are reported in #43

Improvement:

  • Improve host detection with docker internal hostname host.docker.internal
  • Improve overall host detection in different scenarios

Bug fix:

  • TC_HOST environment variable is not respected when set in docker in docker environment

tuvshuud avatar Oct 24 '21 09:10 tuvshuud

@tuvshuud hello. Is this PR still valid? Do you have plans to continue working on this PR?

yakimka avatar Apr 02 '22 15:04 yakimka

@yakimka Hello, I am willing to continue work on this, but not in near few months at least, I afraid.

tuvshuud avatar Apr 03 '22 21:04 tuvshuud

Hey folks, I know this might be an outstanding issue, but a lot of things have happened since this issue was even worked on.

I think it's not worth keeping this issue just on the basis that a few use-cases out there are broken. I'm happy to open similar issues in the future, but we need actual live use-cases with reproducible examples in order to prioritise this, otherwise it's not valuable work.

Closing until further notice.

totallyzen avatar Mar 01 '24 16:03 totallyzen