testcontainers-node icon indicating copy to clipboard operation
testcontainers-node copied to clipboard

Support OneShotStartupCheckStrategy like testcontainers-java

Open omerlh opened this issue 1 year ago • 1 comments

Hey! Very happy users of testcontainers here :) We have a use case where we need something similar to OneShotStartupCheckStrategy that test containers java supports. It is pretty easy to implement it ourselves using StartupCheckStrategy but I am also happy contribute the code back to the library so others could use it as well.

While trying to write and test for it I am getting weird error:

Container runtime strategy "UnixSocketStrategy" does not work TypeError: dockerode.info is not a function 

I added the exception to find out why my tests are not passing and this is the additional string on the error. Happens both locally and when running on codespaces. What am I a doing wrong? I would like help so I could open a pull request - i pushed my (not working changes) to a branch - #730.

omerlh avatar Mar 17 '24 10:03 omerlh

Hey @omerlh, thanks for contributing! I'll reply with feedback on the PR on the PR itself

cristianrgreco avatar Mar 17 '24 11:03 cristianrgreco

Added in https://github.com/testcontainers/testcontainers-node/pull/730

cristianrgreco avatar Jul 12 '24 15:07 cristianrgreco