testcontainers-node icon indicating copy to clipboard operation
testcontainers-node copied to clipboard

Install node dependencies action are not taking right node js version

Open javierlopezdeancos opened this issue 1 year ago • 3 comments

Install Node js dependency action should install the right Node js version per action description

We can see it in each job that execute test with different Node js versions imagen

I think that there is an error in the job github template, fixing it we have the expected behavior, installing the right node version imagen

Close #727

javierlopezdeancos avatar Mar 14 '24 17:03 javierlopezdeancos

Deploy Preview for testcontainers-node ready!

Name Link
Latest commit c4ee7cf1c26d37d5f2ffa3071435e6cf53da060a
Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/66068295a4b7860008cbeedf
Deploy Preview https://deploy-preview-728--testcontainers-node.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 14 '24 17:03 netlify[bot]

Hi @cristianrgreco any ideas about why this job is failing in the Couchbase module? https://github.com/testcontainers/testcontainers-node/actions/runs/8284679078/job/22698328589?pr=728 Something relate tio this change to Node 20.x executions or is something that was appearing previously

javierlopezdeancos avatar Mar 15 '24 19:03 javierlopezdeancos

I've looked into the test failures, seems it's specific to node 20

cristianrgreco avatar Mar 17 '24 10:03 cristianrgreco

I found that tc-java have the same issue https://www.couchbase.com/forums/t/test-container-error-with-image-couchbase-enterprise-7-1-4/36200 There are an open issue to resolve it but, is not clear the approach to fix it https://github.com/testcontainers/testcontainers-java/pull/7049

javierlopezdeancos avatar Mar 26 '24 07:03 javierlopezdeancos