testcontainers-node icon indicating copy to clipboard operation
testcontainers-node copied to clipboard

Allow to use HealthCheck wait strategy by default

Open digital88 opened this issue 5 months ago • 4 comments

#687

Had to augment ImageInspectInfo & ContainerInspectInfo because dockerode types do not expose HealthCheck nested property in Config property. I opened PR here but not sure when it will be accepted.

digital88 avatar Aug 03 '25 13:08 digital88

Deploy Preview for testcontainers-node ready!

Name Link
Latest commit e54c7bbc388b95f23a43cd9c072e10b62bd37d33
Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/68b007178d9c0b000844f357
Deploy Preview https://deploy-preview-1096--testcontainers-node.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Aug 03 '25 13:08 netlify[bot]

I fixed some invalid WaitStrategy references in kafka and red panda. Tests pass locally

digital88 avatar Aug 28 '25 07:08 digital88

@cristianrgreco Hi, is there something else that should be done in this PR? Or we are just waiting for next major release before merging this?

digital88 avatar Aug 31 '25 13:08 digital88

@cristianrgreco Hi, is there something else that should be done in this PR? Or we are just waiting for next major release before merging this?

Hey @digital88, apologies for the delay, been super busy with work lately! I still need to review this PR, but yes you're right it'll eventually get queued for a major release.

cristianrgreco avatar Sep 04 '25 10:09 cristianrgreco