testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Feat/update compose container

Open fokion opened this issue 10 months ago • 5 comments

In the #9222 a user is specifying a property with the field name compose.container.image and the ComposeContainer when it creates the composeDelegate variable is always picking the 24.0.2 version of docker. The change that I am proposing is to use the TestcontainersConfiguration in order to parse the property compose.container.image if it exists otherwise continue as it was in the past. Updated the constructors based on the feedback.

fokion avatar Jan 21 '25 22:01 fokion

Is there any chance this could be fixed soon? It's a simple change, but it has a significant impact — currently, it's blocking our use of the Compose Module in CI.

I've incorporated the review comments in this update; hopefully, this helps move things forward for a quick release. https://github.com/viktorgt/testcontainers-java/tree/feat/update-compose-container

viktorgt avatar Apr 01 '25 14:04 viktorgt

I have updated it with some tests it is failing on a random test on toxiproxy which should not be affected ( maybe it can be rerun ) .Can you have a look again @eddumelendez

fokion avatar Apr 07 '25 08:04 fokion

Any news on this?

viktorgt avatar Apr 17 '25 08:04 viktorgt

Hi our team is also looking to use this feature. Any chance this can be merged? @eddumelendez

chinwobble avatar Jun 06 '25 08:06 chinwobble

Hi @eddumelendez can you review this and maybe merge it :) ?

fokion avatar Jun 14 '25 13:06 fokion

This is also blocking my company to use Testcontainers, would be amazing if this could be merged

omnibrain avatar Jun 26 '25 11:06 omnibrain

still no review from the team ?

fokion avatar Sep 03 '25 15:09 fokion

Thanks for your contribution!

eddumelendez avatar Oct 10 '25 05:10 eddumelendez