testcontainers-java
testcontainers-java copied to clipboard
Feat/update compose container
In the #9222 a user is specifying a property with the field name compose.container.image and the ComposeContainer when it creates the composeDelegate variable is always picking the 24.0.2 version of docker. The change that I am proposing is to use the TestcontainersConfiguration in order to parse the property compose.container.image if it exists otherwise continue as it was in the past. Updated the constructors based on the feedback.
Is there any chance this could be fixed soon? It's a simple change, but it has a significant impact — currently, it's blocking our use of the Compose Module in CI.
I've incorporated the review comments in this update; hopefully, this helps move things forward for a quick release. https://github.com/viktorgt/testcontainers-java/tree/feat/update-compose-container
I have updated it with some tests it is failing on a random test on toxiproxy which should not be affected ( maybe it can be rerun ) .Can you have a look again @eddumelendez
Any news on this?
Hi our team is also looking to use this feature. Any chance this can be merged? @eddumelendez
Hi @eddumelendez can you review this and maybe merge it :) ?
This is also blocking my company to use Testcontainers, would be amazing if this could be merged
still no review from the team ?
Thanks for your contribution!