testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Change the Docker Image used by the Presto module to `prestodb/presto`

Open linghengqian opened this issue 1 year ago • 3 comments

  • Fixes #8657 .
  • Change the Docker Image used by the Presto module to prestodb/presto.

linghengqian avatar Jul 14 '24 18:07 linghengqian

Thanks for your contribution, @linghengqian! In order to fix the build, please run ./gradlew :presto:spotlessApply.

eddumelendez avatar Jul 15 '24 22:07 eddumelendez

Thanks for your contribution, @linghengqian! In order to fix the build, please run ./gradlew :presto:spotlessApply.

  • To keep the original unit tests, I added a few Presto Connector files. There are some additional differences.
  • Presto does not support calling setAutoCommit repeatedly on the same Connection. See https://github.com/prestodb/presto/issues/15916 .
  • Presto does not support the ON TRUE condition for CROSS JOIN UNNEST syntax, and Presto does not support the LEFT JOIN UNNEST syntax. See https://github.com/prestodb/presto/issues/8200 .
  • Presto does not support the FETCH FIRST N ROWS WITH TIES syntax. See https://github.com/prestodb/presto/issues/23223 .
  • I will say that I’m not really sure why unit tests often result in Caused by: com.facebook.presto.spi.PrestoException: No nodes available to run query, as I haven’t been able to find a simple healthCheck method in the Presto documentation that can replace the following. Refer to https://github.com/prestodb/presto/issues/23226 .
this.waitStrategy =
            new LogMessageWaitStrategy()
                .withRegEx(".*======== SERVER STARTED ========.*")
                .withStartupTimeout(Duration.of(60, ChronoUnit.SECONDS));

linghengqian avatar Jul 16 '24 04:07 linghengqian

thanks for the update, @linghengqian ! I see everything green but failing locally. So, hopefully the other issue in presto repository is solved soon and the module can provide a reliable wait strategy.

eddumelendez avatar Jul 17 '24 06:07 eddumelendez