testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

use customized wait strategy in jdbc container

Open whhe opened this issue 1 year ago • 4 comments

Now the abstract class JdbcDatabaseContainer never uses the waitStrategy option, and I think it's better to use the user defined wait strategy when the waitStrategy field is modified.

whhe avatar Jun 06 '24 06:06 whhe

Seems the last commit fails the japicmp check. Should I add these deleted methods to methodExcludes list? @eddumelendez

whhe avatar Jun 06 '24 11:06 whhe

I reverted the latest commit of deleting the waitUntilContainerStarted method, so we can deal with it and the japicmp check later.

whhe avatar Jun 17 '24 06:06 whhe

docker pull quay.io/testcontainers/ryuk:latest got exception:

latest: Pulling from testcontainers/ryuk
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of quay.io/testcontainers/ryuk:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

whhe avatar Jun 17 '24 07:06 whhe

@eddumelendez PTAL

whhe avatar Jun 28 '24 09:06 whhe

I just found #8127 which is trying to fix the same issue, feel free to accept it if you think it's better. @eddumelendez

whhe avatar Jul 08 '24 06:07 whhe