testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

[Enhancement]: JPMS/Automatic-Module-Name

Open mechite opened this issue 2 years ago • 2 comments

Module

Core

Proposal

JPMS isn't supported by this module - Automatic-Module-Name can be added to the manifest for all of the modules or a module-info made.

mechite avatar Jul 29 '23 17:07 mechite

Thanks for raising the issue, @Mechite ! But, this is not something we are going to address soon in out minor versions. There have been attempts to do this #6325 and #6680 (where I forgot about the package's name).

This can be done when Testcontainers reach a major version including the following changes:

  • [ ] Rename modules. E.g. From postgres to testcontainers-postgres
  • [ ] Rename packages. E.g. From org.testcontainers.container to org.testcontainers.postgres

eddumelendez avatar Jul 30 '23 23:07 eddumelendez

indeed there is a split org.testcontainers.container split package shared by jdbc and postgres that prevents modularity happening.

vietj avatar Jun 25 '24 14:06 vietj

The toxiproxy module is also suffering from the org.testcontainers.container split package.

jjohannes avatar Sep 03 '25 11:09 jjohannes