testcontainers-java
testcontainers-java copied to clipboard
Add TiDB module
Add TiDB test container support.
PTAL @eddumelendez @kiview
One month passed, PTAL.
Hey @Icemap, thank you for the contribution, we did not yet have time to review it, sorry.
Please run ./gradlew :tidb:spotlessApply
to fix the spotless errors.
Please run
./gradlew :tidb:spotlessApply
to fix the spotless errors.
@kiview Thanks for the review. And I got this error https://github.com/diffplug/spotless/issues/834 at Java 17 when I run ./gradlew :tidb:spotlessApply
. According to this issue. I added this line at gradle.properties
:
org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
@eddumelendez Yes, we are not interested to provide R2DBC now. Thanks for the review. You're soooooo nice and have a lot of patience!
@eddumelendez does this PR need to change .github/labeler.yml
/ .github/ISSUE_TEMPLATE/enhancement.yaml
/ .github/ISSUE_TEMPLATE/feature.yaml
/ .github/ISSUE_TEMPLATE/bug_report.yaml
/ .github/dependabot.yml
?
[maintainers note] can we automate the check for new modules somehow?
@bsideup Yes, we need to touch those with new modules. We can take care of this for now.
Thanks a lot for all your work @Icemap. I saw you recently started to do some more commits. Are we good to go from your side or is there something you want to work on a bit more?
./gradlew :tidb:spotlessApply
to fix Spotless, sorry.
Recently commits were to fix CI errors. @kiview
Merged, thanks for the great contribution and collaboration @Icemap 🙌