testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Add TiDB module

Open Icemap opened this issue 2 years ago • 8 comments

Add TiDB test container support.

Icemap avatar Jun 21 '22 04:06 Icemap

PTAL @eddumelendez @kiview

Icemap avatar Jun 24 '22 07:06 Icemap

One month passed, PTAL.

Icemap avatar Jul 20 '22 10:07 Icemap

Hey @Icemap, thank you for the contribution, we did not yet have time to review it, sorry.

kiview avatar Jul 20 '22 13:07 kiview

Please run ./gradlew :tidb:spotlessApply to fix the spotless errors.

kiview avatar Jul 20 '22 13:07 kiview

Please run ./gradlew :tidb:spotlessApply to fix the spotless errors.

@kiview Thanks for the review. And I got this error https://github.com/diffplug/spotless/issues/834 at Java 17 when I run ./gradlew :tidb:spotlessApply. According to this issue. I added this line at gradle.properties:

org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED

Icemap avatar Jul 21 '22 03:07 Icemap

@eddumelendez Yes, we are not interested to provide R2DBC now. Thanks for the review. You're soooooo nice and have a lot of patience!

Icemap avatar Jul 22 '22 03:07 Icemap

@eddumelendez does this PR need to change .github/labeler.yml / .github/ISSUE_TEMPLATE/enhancement.yaml / .github/ISSUE_TEMPLATE/feature.yaml / .github/ISSUE_TEMPLATE/bug_report.yaml / .github/dependabot.yml ?

[maintainers note] can we automate the check for new modules somehow?

bsideup avatar Aug 04 '22 10:08 bsideup

@bsideup Yes, we need to touch those with new modules. We can take care of this for now.

kiview avatar Aug 04 '22 13:08 kiview

Thanks a lot for all your work @Icemap. I saw you recently started to do some more commits. Are we good to go from your side or is there something you want to work on a bit more?

kiview avatar Aug 12 '22 08:08 kiview

./gradlew :tidb:spotlessApply to fix Spotless, sorry.

kiview avatar Aug 12 '22 08:08 kiview

Recently commits were to fix CI errors. @kiview

Icemap avatar Aug 15 '22 05:08 Icemap

Merged, thanks for the great contribution and collaboration @Icemap 🙌

kiview avatar Aug 15 '22 14:08 kiview