testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

Java 9: Please add Automatic-Module-Name attribute to META-INF/MANIFEST.MF

Open remal opened this issue 6 years ago • 10 comments

I'm using org.testcontainers:postgresql:1.11.3 dependency and it has no Automatic-Module-Name manifest attribute. It leads to module name conflict, as module name for the dependency is just postgres.

Please add this attribute to all published artifacts. For postgresql it can be smth like testcontainers.postgresql.

remal avatar Jun 03 '19 15:06 remal

Thanks @remal, you are 100% right that this is a PITA and we should fix this soon!

kiview avatar Jun 24 '19 06:06 kiview

This is really needed, there's a conflict between org.testcontainers:postgresql and org.postgresql:postgresql which inhibits the use of both modules!

heruan avatar Aug 07 '19 18:08 heruan

Agreed. We'd happily accept a PR for this, if anyone wants to speed this up.

rnorth avatar Aug 08 '19 09:08 rnorth

I think that #1524 is much more important. Modules names will be useless if projects can't be compiled.

remal avatar Aug 08 '19 16:08 remal

@rnorth would the testcontainers.-prefix be acceptable? So modules will have names like:

  • testcontainers.jdbc
  • testcontainers.mysql
  • testcontainers.postgresql

heruan avatar Aug 08 '19 21:08 heruan

@rnorth I've issued the PR to speed this up, hope the module names are fine otherwise I'll change them!

heruan avatar Aug 09 '19 07:08 heruan

BTW @remal it totally right, fixing module names still does permit to use them since different modules share the same package name org.testcontainers.containers which is not permitted by the spec:

Non-interference — The Java compiler, virtual machine, and run-time system must ensure that modules that contain packages of the same name do not interfere with each other. If two distinct modules contain packages of the same name then, from the perspective of each module, all of the types and members in that package are defined only by that module. Code in that package in one module must not be able to access package-private types or members in that package in the other module.

— http://openjdk.java.net/projects/jigsaw/spec/reqs/#non-interference

So also #1524 should be fixed as soon as possible.

heruan avatar Aug 09 '19 08:08 heruan

I'm wondering about the status of this since it is a blocker for any modular project.

The two problems seem to be that testcontainers contains split packages and does not declare a stable module name. Declaring a module name is not very useful without resolving the split packages, of course. Renaming this issue might be useful since it is not merely adding an automatic module name.

By the way, there are a number of duplicates of this issue. Maybe you would like to consolidate them:

  • https://github.com/testcontainers/testcontainers-java/issues/521
  • https://github.com/testcontainers/testcontainers-java/issues/1524
  • https://github.com/testcontainers/testcontainers-java/issues/1917

Agreed. We'd happily accept a PR for this, if anyone wants to speed this up.

As I understand it, fixing the split packages will require API changes. Is the 2.0 version already in development?

A248 avatar May 28 '21 16:05 A248

Is there any news about this issue? As it is currently not possible to use testcontainers in a modular project, which is a real shame. Has anyone worked on this? I'd be happy to help

shedfull avatar May 18 '22 13:05 shedfull

The outlined issues are still valid, mostly the split package problem. Do you have any experience on mitigating this, without breaking changes?

kiview avatar May 19 '22 15:05 kiview