testcontainers-hs icon indicating copy to clipboard operation
testcontainers-hs copied to clipboard

Have two different packages for Hspec and Tasty

Open michivi opened this issue 3 years ago • 3 comments

Question

Would it be possible to have two different packages, one for Hspec and one for Tasty?

Currently, when one chooses to use Hspec (resp. Tasty), they also have to compile Tasty (resp. Hspec) as testcontainers-hs uses both as dependencies. But they won't actually use it.

Perhaps having something like this could help:

  • The testcontainers-hs-core package would have all the definitions required to use testcontainers-hs, whether we're a Hspec user or Tasty user.
  • The testcontainers-hs-hspec package for Hspec users
  • The testcontainers-hs-tasty package for Tasty users

Do you think something like that would be doable? Thanks in any case 🙂

michivi avatar Oct 10 '22 17:10 michivi

Sure definitely doable. Happy to accept contributions. But my question is, does it really matter? Compiling dependencies is a one time thing, no?

alexbiehl avatar Oct 10 '22 19:10 alexbiehl

Right, but it still feels unnecessary to build tasty and its dependencies when we're using hspec. In CI, we would also use unnecessary storage for the compiled binary, though surely not significantly to be important. In any case, I guess this sure sounds low-priority as nothing is broken. If I have time, I'll try to tackle it 🙂

michivi avatar Oct 11 '22 06:10 michivi

Sounds good!

alexbiehl avatar Oct 11 '22 06:10 alexbiehl