testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

[Enhancement]: Add banner when Ryuk is disabled

Open mdelapenya opened this issue 3 years ago • 0 comments

Proposal

This banner will warn the user about unexpected behavior if Ryuk is disabled. See https://github.com/testcontainers/testcontainers-java/pull/5929

The banner should be displayed only once per test execution, so we probably need to change how the reaper is called from the container request: instead of having a field at the request level, it should be a global config:

  • a properties at .testcontainers.properties
  • an environment variable: TESTCONTAINERS_RYUK_DISABLED, which if present precedes the property

If Ryuk is disabled, then the banner would be shown, just once.

The SkipReaper property from the container request should be deprecated in consequence.

mdelapenya avatar Oct 04 '22 14:10 mdelapenya