testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Published 20 hours ago • verified publisher icon testcontainers

add containerised docker compose and tests

Open mazitovt opened this issue 2 years ago • 2 comments

Feature for Issue #425

Added ContainerisedDockerCompose struct with embedded LocalDockerCompose and override all DockerCompose methods. Added two functions executeInContainer and executeComposeInContainer, that work with docker/compose container.

mazitovt avatar Jun 15 '22 01:06 mazitovt

@mdelapenya, hi. You've mentioned my PR, but never gave a feedback. Can you please review it?

mazitovt avatar Jun 23 '22 10:06 mazitovt

@mdelapenya, hi. You've mentioned my PR, but never gave a feedback. Can you please review it?

Hi @mazitovt this compose has different "rivals" :)

  • https://github.com/testcontainers/testcontainers-go/pull/462
  • and more importantly this discussion about the future of compose: https://github.com/testcontainers/testcontainers-go/issues/425#issuecomment-1165237887

I pinged you in the issue just in case you want to participate in it to design what compose APIs we want to have

Again, sorry if I should have been more responsive in this PR 🙏

mdelapenya avatar Jun 28 '22 08:06 mdelapenya

Hi @mazitovt we have merged #476, which adds native support for docker compose, deprecating the local docker compose implementation. I'm not sure if we'd need a dockerised one now that we can run it natively, but wanted to check with you first before closing this issue.

mdelapenya avatar Oct 24 '22 11:10 mdelapenya

@mdelapenya ok. I close my PR.

mazitovt avatar Oct 25 '22 20:10 mazitovt