testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

Update go-redis to v8.11.5

Open johanoskarsson opened this issue 2 years ago • 2 comments

Brings the go-redis package up to the latest version.

Ran the test that uses redis: Test_BuildContainerFromDockerfile locally and it passes. Side note: when I try to run all the tests in the repo on main I get failures. Not sure if that has to do with my local setup or if main is broken?

johanoskarsson avatar Apr 04 '22 21:04 johanoskarsson

Codecov Report

Merging #424 (d1b08e1) into main (7d22247) will decrease coverage by 0.48%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   70.16%   69.67%   -0.49%     
==========================================
  Files          21       21              
  Lines        2048     2048              
==========================================
- Hits         1437     1427      -10     
- Misses        490      497       +7     
- Partials      121      124       +3     
Impacted Files Coverage Δ
docker.go 71.12% <0.00%> (-1.07%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Apr 04 '22 21:04 codecov[bot]

Looked at the failing test but I'm not sure it's related to this PR?

johanoskarsson avatar Apr 04 '22 22:04 johanoskarsson

This should be ready for a re-review now. Thanks!

johanoskarsson avatar Aug 26 '22 23:08 johanoskarsson

HI @johanoskarsson I did not review it on purpose as we have to internally discuss about modules, and because we are adding a dependency on redis to downstream users, I'd like to maybe move that dependency (and its tests) to an eventual Redis module.

Of course, because this change is totally harmless, it can make it to the next release (hopefully super soon)

mdelapenya avatar Aug 29 '22 16:08 mdelapenya