testcontainers-go
testcontainers-go copied to clipboard
add basic auth support
Codecov Report
Merging #301 (5a21132) into main (7d0afb7) will increase coverage by
0.75%
. The diff coverage is100.00%
.
:exclamation: Current head 5a21132 differs from pull request most recent head 0cd273c. Consider uploading reports for the commit 0cd273c to get more accurate results
@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 68.88% 69.64% +0.75%
==========================================
Files 22 21 -1
Lines 2144 1957 -187
==========================================
- Hits 1477 1363 -114
+ Misses 528 475 -53
+ Partials 139 119 -20
Impacted Files | Coverage Δ | |
---|---|---|
wait/http.go | 63.97% <100.00%> (+4.44%) |
:arrow_up: |
generic.go | 67.85% <0.00%> (-7.15%) |
:arrow_down: |
docker.go | 69.63% <0.00%> (-1.20%) |
:arrow_down: |
container.go | 80.72% <0.00%> (ø) |
|
wait/wait.go | 100.00% <0.00%> (ø) |
|
file.go | ||
wait/host_port.go | 57.69% <0.00%> (+9.27%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Hi @nevins-b thanks for this contribution. At first sight seems ok, but we'd like to add tests covering this new behavior. Also if you could provide context about the need for this contribution that could help us in the review process.
Thank you!!
For context this was initially to support the opendistro ES container (https://opendistro.github.io/for-elasticsearch-docs/docs/install/docker/) which launches with basic auth on all endpoints
Deploy Preview for testcontainers-go ready!
Name | Link |
---|---|
Latest commit | 0cd273cb842f12bcbc7c81734b6a791e6c66120f |
Latest deploy log | https://app.netlify.com/sites/testcontainers-go/deploys/63fddc4a6d0fc7000796a886 |
Deploy Preview | https://deploy-preview-301--testcontainers-go.netlify.app/features/wait/http |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@nevins-b I've polished the PR a bit, updating the existing docs for the HTTP wait strategy. So I'm going to merge this PR.
Thanks for your initial work here! 🙇