testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

fix(kafka): Fix internal docker connection

Open mdelapenya opened this issue 1 year ago • 2 comments

What does this PR do?

Follow-up of #2490 in order to be able to push commits and make progress.

Why is it important?

Give importance to @catinapoke's work in #2490, keeping the commits (and authorship), and doing the toil tasks for them. This way we can push to this feature branch (the original PR is using the main branch, so we cannot update it)

Related issues

  • Supersedes #2490

mdelapenya avatar Nov 21 '24 15:11 mdelapenya

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 67c3480961ffdb61c1c72510deb79e686e9a4ef6
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67447ef10348ba00083ff40a
Deploy Preview https://deploy-preview-2894--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 21 '24 15:11 netlify[bot]

@stevenh I addressed the majority of your comments: all except those related to the TestKafka_networkConnectivity test, which is still failing for me locally.

mdelapenya avatar Nov 25 '24 13:11 mdelapenya