testcontainers-go icon indicating copy to clipboard operation
testcontainers-go copied to clipboard

feat: copy from host to container

Open stevenh opened this issue 1 year ago • 1 comments

Add CopyHostPathTo to container methods, which is capable of copying files and directories from the host to a container. It identifies the correct copy semantics based on inspecting the source and target, replicating the behaviour of docker cp and other OS copy tools.

This deprecates CopyDirToContainer and CopyFileToContainer while still correcting their behaviour to also match docker cp behaviour.

Replace nonamedreturns linter with nakedret, as nonamedreturns prevents naming returned parameters which has a number of valid uses including: disambiguating return values and error checking.

Copying files to the container now doesn't compression as this is slower and consumes more resources for the typical local transfer case.

Fix docker copy tests to they validate the correct behaviour by ensuring that done is reported to the container log.

Clean up some error wrapping.

Fixes #2780

stevenh avatar Sep 16 '24 17:09 stevenh